[Pygments] Cleanup metaclass workarounds for mypy<1.1#15607
Merged
srittau merged 2 commits intopython:mainfrom Apr 5, 2026
Merged
[Pygments] Cleanup metaclass workarounds for mypy<1.1#15607srittau merged 2 commits intopython:mainfrom
srittau merged 2 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
cc @Akuli for being involved with the previous iterations and for porcupine |
brianschubert
force-pushed
the
stubs-pygments-metaclass-workarounds
branch
2 times, most recently
from
64d15ca to
b169297
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine)
+ porcupine/plugins/pastebin.py:193: error: Incompatible return value type (got "str | None", expected "str") [return-value]
+ porcupine/plugins/pastebin.py:193: error: "LexerMeta" has no attribute "aliases" [attr-defined]
rich (https://github.com/Textualize/rich)
- rich/syntax.py:414: error: "Lexer" has no attribute "aliases" [attr-defined]
- rich/syntax.py:415: error: "Lexer" has no attribute "aliases" [attr-defined]
- rich/syntax.py:417: error: "Lexer" has no attribute "name" [attr-defined]
- rich/traceback.py:763: error: "Lexer" has no attribute "name" [attr-defined]
|
srittau
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were workarounds for mypy deficiencies that have since been fixed. See #9803
Also change the type of
Style.aliasfromlist[str]toSequence[str]